On 10/08/2015 04:48 PM, Lukas Slebodnik wrote:
On (08/10/15 16:29), Nikolai Kondrashov wrote:
> On 10/08/2015 11:39 AM, Lukas Slebodnik wrote:
>> On (08/10/15 10:33), Pavel Reichl wrote:
>>>
>>>
>>> On 10/08/2015 09:32 AM, Lukas Slebodnik wrote:
>>>>
>>>> Pavel R.,
>>>> could these patches used with your tests for local override?
>>>>
>>>> LS
>>>>
>>>
>>> I'll have to amend the patches, but that was agreed to. Seems that
functionality I need is there so fine by me.
>>
>> Nikolai,
>>
>> please fix pep8 warnings in first 5 patches so we can push them
>> and unblock other patches.
>
> I'm doing that right now. However, should we really comply with the following
> warnings?
>
> E126 continuation line over-indented for hanging indent
> E131 continuation line unaligned for hanging indent
> E221 multiple spaces before operator
> E241 multiple spaces after ','
> E251 unexpected spaces around keyword / parameter equals
>
> These complain about whitespace which is used to try to format the code better
> for humans and is subjective. Do we agree with them? Or can we keep our
> formatting?
>
I ask our collegues from FreeIPA team and they follow these pep8
recommendations. Most of us are not python experts so it would be good to
the follow the same quidelines as they.
Argh. OK.
They do not strict require 80 characters per line.
I'd like to keep that requirement.
I'll try to follow with a patch fixing the rest of the issues in the code (not
just introduced with these patches).
Nick