On Tue, 2010-07-27 at 14:26 -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
On 07/27/2010 11:04 AM, Martin Nagy wrote:
> On Mon, 2010-07-26 at 22:26 +0200, Martin Nagy wrote:
>> On Mon, 2010-07-26 at 16:14 +0200, Jakub Hrozek wrote:
>> Thanks for review/testing.
>>> I could not perform GSSAPI auth against FreeIPA 2 server:
>>> [sssd[be[IDM.LAB.BOS.REDHAT.COM]]] [ldap_sasl_interactive_bind_try] (1):
>>> ldap_sasl_bind failed (-6) [Unknown authentication method]
>> Fixed, stupid copy&paste error. I also fixed the problem reported by
>> Jeff (thanks for testing!), which was also a stupid error. I also tested
>> the patch with openldap-2.3.43 on RHEL5 and fixed one compilation issue
>> (missing ldap_controls_dup() function).
> Additional fix of a bug found by Jakub off-list (plus one or two
> cosmetic fixes).
I added a few review comments here:
Ah, sorry, I still didn't have time to add the comments you wanted and
make a new patch. However, I've created a design document  as you
asked off-list. It still is not complete, especially in regards to the
guard/spy, I'm planning on completing that tomorrow.