On Fri, May 30, 2014 at 12:23:02PM -0400, Simo Sorce wrote:
On Fri, 2014-05-30 at 18:09 +0200, Pavel Březina wrote:
> On 05/30/2014 05:59 PM, Yassir Elley wrote:
> >
> >
> > ----- Original Message -----
> >> On Fri, May 30, 2014 at 05:52:29PM +0200, Pavel Březina wrote:
> >>> On 05/30/2014 05:41 PM, Yassir Elley wrote:
> >>>>
> >>>>
> >>>> ----- Original Message -----
> >>>>> On Fri, May 30, 2014 at 11:27:25AM -0400, Yassir Elley wrote:
> >>>>>> I pulled in the ifp changes, and ran "chmake"
> >>>>>>
> >>>>>> Considering I had not touched any of the ifp files, I was
surprised to
> >>>>>> find
> >>>>>> that "git status" said:
> >>>>>> "modified:
../src/responder/ifp/ifp_iface_generated.c"
> >>>>>>
> >>>>>> Is this expected??
> >>>>>>
> >>>>>> Regards,
> >>>>>> Yassir
> >>>>>
> >>>>> No, unless you touched either sbus_codegen or the infopipe
XML.
> >>>>>
> >>>>> Is that reproducable easily?
> >>>>> _______________________________________________
> >>>>> sssd-devel mailing list
> >>>>> sssd-devel(a)lists.fedorahosted.org
> >>>>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>>>>
> >>>>
> >>>> Yes, it is reproducible.
> >>>>
> >>>> From a feature branch on which I had some changes, I did the
following:
> >>>> $ git rebase origin/master => successful
> >>>> $ reconfig
> >>>> $ git status => no changes
> >>>> $ chmake
> >>>> $ git status => modified:
../src/responder/ifp/ifp_iface_generated.c
> >>>>
> >>>> I only noticed it b/c I was trying to change branches, and git was
> >>>> indicating that I need to stash the changed files (which I
didn't
> >>>> change).
> >>>>
> >>>> Regards,
> >>>> Yassir.
> >>>
> >>> Building current master does not yield any changes in the generated
> >>> files for me.
> >>
> >> I can reproduce the issue (or a similar one?) when I switch branches..
> >> _______________________________________________
> >
> > Building current master also does not yield any changes for me. It is only when
building on a feature branch the very first time after having pulled in the ifp changes.
> >
> > Yassir.
>
> Anyway, I think we should add the generated code into git ignore and
> leave it out of git completely.
Nope, it makes it much harder to see:
a) what is the consequence of a change in the generator.
b) browse the source with git grep or browsing with other tools w/o
building it
+1, especially a) but also b) is important for tools like cscope. If we
ignored the generated code, it would have to be in $builddir, not
$srcdir and then using cscope would be much harder.
What we may want to consider is to not autogenerate the code at every
build, but rely on people changing the templates to run the generator
before committing.
Simo.
I think it's simply a bug in the generator. I played a bit more with the
diff that is generated and it seems that the content is the same, just
moved in the file. I would have expected that given the same input, same
output would be generated.
Right now, I suspect there is a different order in which pieces of the
interface are generated, but I'm not going to block the beta release
over that.
I filed:
https://fedorahosted.org/sssd/ticket/2344
And we'll tackle the problem in beta2.