On 07/07/2010 04:43 PM, Stephen Gallagher wrote:
> Sounds good. I just want a confirmation that it is in line with
tevent
> coding style to pass pointer to higher level state (hbac_ctx) into
> sub-operations (hbac_get_host_info_send() and others).
>
It's fine to percolate it down where necessary, provided that the
functions it's going into must ALWAYS be a descendent. (E.g. it's okay
to pass it into helper requests, but passing it into sdap_generic_send()
would be a mistake)
An updated version of
0010-Use-new-LDAP-connection-framework-in-IPA-access-back.patch
is attached.
Can you take a look at it? I'd like to know whether the approach is in
line with the coding guidelines.
The second question is: do I need to split this patch in 2: the first
for passing hbac_ctx into stages and the other for a change to new LDAP
connection framework?
Eugene Indenbom