-----BEGIN PGP SIGNED MESSAGE-----
On 01/03/2011 06:12 PM, Dmitri Pal wrote:
Please see the attached patches. I tried to split the patches
into manageable sets.
Unfortunately I made a minor mistake and I am afraid I will do something
wrong to fix it.
I merged two wrong patches. Fortunately it was three liner with 1 liner
so it is not a big of the deal but I am really scared that I will do
something wrong and loose the work I have done.
So I hope it is Ok to send it as is.
0001--INI-Making-Coverity-happy.patch <- this is the patch I submitted
earlier that I merged by mistake. I was supposed to merge it with patch
25 but picked the wrong one instead.
Patch 25 addresses the real issue found by Coverity as mentioned in
Stephen's review mail but it did not apply cleanly since it relies on
some code from the patches in the middle.
I split this patch. I'm attaching the missing initializer patch. That
gets an ack.
However, the 100078/79 fix is not correct. I did some digging and found
the real problem. If you look at line 264 and 279 of ini_valueobj_ut.c,
it's possible for other_create_test() to return EOK without having
modified the vo variable. As a result, you will be passing the
uninitialized value to modify_test(). So Coverity is right that there's
a possibility of it passing a freed variable here.
So the Coverity fix gets a nack.
0002--INI-Adding-missing-function-declararion.patch <- this is
patch that was rejected from the second set sent earlier. Fixed
according to review comment.
0003--BUILD-Allow-trace-per-component.patch <- This patch allows
Nack. Requiring a file doesn't make sense. Just add --enable-trace-ini,
- --enable-trace-collection etc. flags.
The following set of patches introduces the merging of sections
the reading of the file:
It would be better to use an enum here instead of #defines, then your
last entry for ERR_MAXPARSE will always be one higher than your previous
See sdap_basic_opt in src/providers/ldap/sdap.h in the SSSD source code
for an example.
That said, there's nothing WRONG with this patch, so ack.
I don't much like the idea
of having flags that have overlapping bits
without an obvious reason (0x0020 and 0x0030, for example), but since
those are pre-existing, I'll leave them alone. Ack.
Ack, though it
seems to me that a memset to zero would be simpler than
manually setting every struct member to zero manually.
Nack. It doesn't
make sense to pass in an index value to an array local
only to the function. That's not clean. It would be better to either
pass in the const char * for the message, or at worst pass in an enum
type that you would use to look up the matching error message.
will need to be updated to correspond to the changes for
Nack. Please fix
the formatting of the switch statement. There should be
only one level of indent following the case tag.
fix random tabs in the indentation. Otherwise it looks fine.
I'll review the porting patches in a separate email. This should be
enough to get you started in the meantime.
Patches related porting of the meta data from old way of doing things to
the new way of doing things:
0021--INI-Avoid-double-free.patch <- patch related to 17 (missed check)
0024--INI-Rename-error-print-function.patch <- rename error printing
function for consistency with new interface
0025--INI-Initialize-variables-in-loops.patch <- Coverity issue
addressed. Related to patch 0001.
0026--INI-Exposing-functions.patch <- Make some internal functions reusable
There is also patch 27. It is a piece of new functionality. It is a
preview. Please see the comment before reviewing it.
Do I need to split it into multiple patches or it is Ok as is? It is
pretty big but all changes are in one file and logically related.
The UNIT test is missing so I am not claiming it actually works as
sssd-devel mailing list
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----