-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/15/2010 04:01 AM, Jakub Hrozek wrote:
On 10/14/2010 08:48 PM, Stephen Gallagher wrote:
> Patch 0001: Ack.
> Patch 0002: Nack
> I'd rather you used sysdb_attrs_get_string() to get the SYSDB_NAME in
> sdap_add_incomplete_groups().
Done.
> strtol() is also not safe here, as gid_t is a uint32_t, which on 32-bit
> platforms may require unsigned long.
Done. But IIRC I copied this bit from elsewhere in the code. Do we want
to have a cleanup ticket to use the new sysdb_attrs_get_ulong() facility?
Please open a ticket. If possible, please try to fix this in time for
1.4.0. I have a feeling we have issues with handling high-value UID/GIDs.
I'm going to ask QE to test this.
> Also, since it would be a very useful thing to have, please add
a
> function sysdb_attrs_get_ulong() and use that for getting the GID.
This is implemented in new patch 0001.
Review coming a little later.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAky4Nx8ACgkQeiVVYja6o6O18ACgnBOO2IOQXBMt/2kj6ixbqdDI
QPoAn030x757jmtxtYkqBu4IXFTszX0t
=PN89
-----END PGP SIGNATURE-----