From b0f5ccffb400d6dc8b23208239adc6522b0622c0 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 18:57:22 +0100 Subject: [PATCH] TOOLS: Prevent dereference of null pointer VAR_CHECK is called with (var, EOK, ...) EOK would be returned in case of "var != EOK" and output argument _attrs would not be initialized. Therefore there could be dereference of null pointer after calling function usermod_build_attrs. --- src/tools/sss_sync_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c index 5468929b691c6539cdf55f59be3560412e398f21..8e78c57880f5236569d690df90e6c82d4fd6e1ea 100644 --- a/src/tools/sss_sync_ops.c +++ b/src/tools/sss_sync_ops.c @@ -38,9 +38,9 @@ #define ATTR_VAL_SEP ',' #define VAR_CHECK(var, val, attr, msg) do { \ - if (var != (val)) { \ + if ((var) != (val)) { \ DEBUG(SSSDBG_CRIT_FAILURE, msg" attribute: %s\n", attr); \ - return val; \ + return (var); \ } \ } while(0) -- 2.7.2