I sent a response on July 6th but perhaps there was an issue with the mailing list or some reason it did not go through.
Updated patch attached.
I moved the resolv_is_address() function declaration into the async_resolv.h file(so that it could be included in the cmocka/test_resolv_fake.c test but I am not sure if this is the correct approach). I also made the assumption of including my tests in the already existing test_resolv_fake.c file instead of a different file.
Also, I wasn't sure whether to use SSSDBG_MINOR_FAILURE or SSSDBG_CONF_SETTINGS debug log level.
I am sure there are some corrections to make so I appreciate any feedback.
Kind regards, Justin Stephenson
On (26/02/16 09:47), Justin Stephenson wrote:Thanks a lot for the feedback, I am new to the cmocka framework so I will take some time to learn it and respond after amending the patch.Justin, do you plan to update the patch? LS