On Thu, Oct 11, 2012 at 01:37:49PM +0200, Jakub Hrozek wrote:
On Thu, Oct 11, 2012 at 01:28:03PM +0200, Sumit Bose wrote:
> On Thu, Oct 11, 2012 at 10:00:15AM +0200, Jakub Hrozek wrote:
> > When a PAM-aware application calls pam_end(), our module would call its
> > close_fd "destructor" and close the pipe from its end.
> >
> >
https://fedorahosted.org/sssd/ticket/1569
>
> Patch looks good, I just wonder if pam_set_data() better should be
> called directly after sss_pam_make_request() to make sure the socket is
> closed even in the case of errors in sss_pam_make_request() or
> eval_response() ?
>
> bye,
> Sumit
Yes, it should. I've also made the failure of pam_set_data() non fatal.
good point. ACK
bye,
Sumit
Thank you for the review!