On Thu, Jan 21, 2010 at 04:08:27PM +0100, Sumit Bose wrote:
On Fri, Jan 08, 2010 at 03:30:32PM +0100, Sumit Bose wrote:
> On Fri, Jan 08, 2010 at 03:10:21PM +0100, Tomas Mraz wrote:
> > On Fri, 2010-01-08 at 15:01 +0100, Sumit Bose wrote:
> > > Hi,
> > >
> > > this patch just renames PAM_USER_INFO to PAM_SYSTEM_INFO. Currently
> > > PAM_USER_INFO is only used to send messages which are written to syslog
> > > by the PAM client. It is planned to add new messages which will be
> > > displayed to the user, e.g. if offline authentication was used. To avoid
> > > confusion I think this name change makes sense.
> >
> > I suggest to rename all the PAM_ prefixed constants which do not come
> > from PAM library directly to SSSPAM_ prefix to avoid confusion or name
> > conflict with the PAM library. Although I understand that is possibly an
> > API break.
> >
>
> I like this idea, I'll try to prepare a patch for this.
>
I have added a new patch which changes all defines and enum values
starting with PAM_ to SSS_PAM_. For your convenience I've added to
original patch, too.
rebased to current master.
bye,
Sumit