On Thu, Oct 11, 2012 at 03:21:07PM -0400, Simo Sorce wrote:
> > NACK, ^^^^^^^^^
>
> I'm sorry Simo but your Nack came too late after I pushed the patch and
> before I sent a pushmail, so I'll attach a fix.
>
> As discussed off-list already I will CC you with any future client
> patches.
>
> > you are closing the fd and leaving sss_cli_sd untouched, which means it
> > will still point to a random file descriptor.
> >
>
> fixed
>
> > Also I do not understand why this whole dance in passing pointers and
> > the sss_pam_get_socket() function, seem all very unnecessary.
> > .
> > sss_cli_sd is a global variable which means:
> > a) you can access it directly
>
> Yes and no, it's local to the sss_client/common.c module, so I moved
> closing the socket there.
>
> > b) you need mutexes to access it (see sss_pam_make_request()).
>
> fixed
>
> The attached fix should amend the code as you suggested.
ACK
Simo.
Pushed to master.