On 08/25/2014 03:40 PM, Pavel Reichl wrote:
Hello,
I have prepared patches for
https://fedorahosted.org/sssd/ticket/2343
Patches actually do not work due to same bug which is causing
https://fedorahosted.org/sssd/ticket/2407.
So my patches are effectively blocked by #2407, for testing purposes
following command may be used (which reverts patches introducing the bug):
git revert 983983dd1629ab33eab340a40d9ee83965a339c6
ed346bcc84b8a326996e5550771773d8e63f17c2
Thanks,
Pavel Reichl
Hi,
I just have one question.
Patch 0001:
- state->group_dns[state->cur], count);
+ state->group_dns[state->cur], count);
Btw. I do not think this change was necessary, but OK, we can keep it :)
Ack.
Patch 0002:
- /* When not ID-mapping, make sure there is a non-NULL UID
*/
- state->base_filter = talloc_asprintf_append(state->base_filter,
- "(&(%s=*)(!(%s=0))))",
- opts->group_map[SDAP_AT_GROUP_GID].name,
- opts->group_map[SDAP_AT_GROUP_GID].name);
+ state->base_filter = talloc_asprintf_append(state->base_filter,
")");
This is the change I was worried about most. It did not break anything
I tested, but the comment seem to be there for a reason. Do you know
why the comment was there in the first place? I would like to Ack this
patch, but I am not sure if we are not breaking something with this.
Patch 0003: Ack.
The problem with not listing all members of a group still remains in
trusted scenario (IPA<->AD trust, SSSD is client of IPA). If the
group hierarchy is located on AD we do not get proper results.
But this should be solved separately.
Michal