On Sun, May 30, 2010 at 1:25 PM, Jakub Hrozek <jhrozek(a)redhat.com> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/28/2010 08:59 PM, Jeff Schroeder wrote:
> Tested against master and cherry-picked to sssd-1-2. Applies cleanly to both.
>
Jeff,
thank you for the patch, but can you describe if you had any problem
without it? RPM is usually pretty good in determining runtime
dependencies, so adding explicit Requires: should not be necessary.
Yes, I tried rpm -Uvh *.rpm on an existing sssd host (1.0.5 +
enumerate=False cpu hog fix cherry picked). The rpm install failed due
to libsemanage.so.6 missing.
If you are adding _new_ dependencies like this, it is my thought it
should be explicit in the spec file. When I asked on IRC simo said to
go ahead and send the patch out. What do you think?
--
Jeff Schroeder
Don't drink and derive, alcohol and analysis don't mix.
http://www.digitalprognosis.com