On Fri, 2011-07-29 at 14:59 +0100, John Hodrien wrote:
On Fri, 29 Jul 2011, Stephen Gallagher wrote:
> This patch looks pretty good, John, but would you mind submitting it
> following the instructions at
>
https://fedorahosted.org/sssd/wiki/Contribute#SourceCodeRepository and
>
https://fedorahosted.org/sssd/wiki/BugLifecycle#Whattodowhenyoureworkingo...
please?
>
> It makes it easy to maintain attribution. Also, please ensure that your
> code corresponds to the style guidelines at
>
http://www.freeipa.org/page/Coding_Style (I can't tell from the
> copy-pasted patch in the email).
Ignoring me being a dozy fool and making a bit meal of creating it correctly,
I've hopefully done this as #945.
As far as I could tell it's compliant with the coding style.
Yup, I saw the bug. I'd still have preferred you to create the patch
with 'git format-patch -M -C --patience --full-index -1', but I can
handle that for you.
Thanks for the patch!