On 08/18/2015 01:19 PM, Petr Cech wrote:
On 08/05/2015 11:23 AM, Jakub Hrozek wrote:
>>> B)
>>> > >While writing a patch Lukas noticed another similar logging
>>> messages
>>>> > >>[sssd[pam]] [sss_dp_get_account_msg] (0x0400): Creating
>>>> request for
>>> > >[LDAP][3][1][name=mof_user6]
>>> > >
>>> > >I investigated it. This is the same thing -- BE_REQ_*, but it is
>>> no longer
>>> > >in the provider, but in the responder. Can you please advise me
>>> where I
>>> > >could the function 'be_req2str' write?
>> >I think you should move it to separate file, as you don't want to
>> share more
>> >code then necessary.
>> >There are 2 possibilities where to have this file
>> >a) in src/providers - responders already link with some modules
>> from this
>> >folder, so I suppose it's viable
> Yes, this is a bit of hierarchy violation, but in the end we need to
> share the constants somehow. I think it's fine to keep the definite
> version in the providers/dp_* hierarchy, because that's where the
> interface is defined, the responder is a consumer.
>
There is new patch attached.
I think, that constants and const2str() functions should be in one
place. I tried to suggest how we might share our constants. That's why
I created a new header file in which we could move all the constants
in the future.
I am open to discussion. I look forward to your views.
Petr
Hello Petr,
make dict check fails:
/workspace/ci/label/rhel7/ci-build-debug/sssd-1.13.1/_inst/share/locale\" -g3 -O2
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c ../src/providers/ldap/ldap_id.c -fPIC -DPIC
-o src/providers/ldap/.libs/libsss_ldap_common_la-ldap_id.o
../src/providers/ldap/ldap_id.c:33:41: fatal error: providers/data_provider_req.h: No
such file or directory
#include "providers/data_provider_req.h"
you can fix this by something
like:
Makefile.am
@@ -584,6 +584,7 @@ dist_noinst_HEADERS = \
src/confdb/confdb_private.h \
src/confdb/confdb_setup.h \
src/providers/data_provider.h \
+ src/providers/data_provider_req.h \
I think that data_provider_req.h should be included in data_provider.h,
you could save a lot of changes in source files that require both of them.