URL:
https://github.com/SSSD/sssd/pull/601
Author: pbrezina
Title: #601: sbus: integrate sssd with sbus2
Action: opened
PR body:
"""
Hi folks,
this is a really large patch set and I have now idea how to review it.
I know that Jakub tried to review the proof of concept, but he have not
managed to finish it so far. It is not in human power to review it all
so hard testing should be done.
I consider the code itself and the integration with sssd finished. I will
push only bug fixes and review issues now. This first version does not
run through make check so far because some tests needs to be altered,
this however does not prevent manual testing and reviewing.
I tried to make the changes small at first while running old and new sbus
in parallel, but it was too hard as the changes were too much interconnected.
Therefore each patch modifies one area, but completely and sssd will not build.
There are new libraries, each in pair. Each pair consist of asynchronous
(used inside sssd) and synchronous (used inside tools; sssctl) versions of API.
- libsss_sbus, libsss_sbus_sync: sbus interface
- libsss_iface, libsss_iface_sync: internal sssd interface, used for internal
communication
- libifp_iface, libifp_iface_sync: infopipe interface
At this point, changes are mostly one to one. We still have separate server for monitor
and
backends. We still do not use signals, even though it is possible. I will file separate
tickets with ideas how to improve our api further and we can work together after
this patch set is tested and merged.
I did my best with manual testing but I doubt I run all the scenarious. Especially, I
want
to ask @sbose to test ifp smartcard API and @fidencio to test Fleet Commander integration
(the one dbus call in ipa code).
Thank you.
"""
To pull the PR as Git branch:
git remote add ghsssd
https://github.com/SSSD/sssd
git fetch ghsssd pull/601/head:pr601
git checkout pr601