On 03/07/2013 02:41 PM, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu 07 Mar 2013 08:17:19 AM EST, Ondrej Kos wrote:
> Hi,
>
> Attached find patch introducing support of the libnl3 netlink
> library. The SSSD now builds with libnl3 by default, but is still
> configurable to use the libnl in version 1 by adding configure
> parameter --with-netlink-lib=libnl
>
Nack. I haven't reviewed all of the code, but I notice that you
changed the configure script so that it can no longer opt to build
without netlink at all. We want to leave this option available, I
think. There are porting efforts going on for non-Linux systems (I'm
aware of at least one *BSD that's trying to port SSSD).
I'll leave the review of the actual code to Jakub, as I believe he
wrote the Netlink v1 support.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iEYEARECAAYFAlE4mPIACgkQeiVVYja6o6P7kQCdFYvnpuFByprNKX8DkyBeTCOG
O4oAnjBV3/84UVlHroNJEQztxvqR2gsx
=fBU+
-----END PGP SIGNATURE-----
I forgot about the option with no netlink support at all, I'll wait for
the review, if there's more repairs to do, and prepare new patch.
Ondra
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #sssd #brno