On Wed, Jun 04, 2014 at 05:41:14PM +0200, Lukas Slebodnik wrote:
> On (04/06/14 17:34), Sumit Bose wrote:
> >On Wed, Jun 04, 2014 at 04:40:41PM +0200, Pavel Reichl wrote:
> >> Hello,
> >>
> >> while working on
> >>
https://fedorahosted.org/sssd/ticket/2056
> >> I noticed this already applied patch
> >>
http://fedorapeople.org/cgit/sbose/public_git/sssd.git/commit/?id=48eb2ca...
> >>
> >> What's the best course of action now?
> >> 1) Simply close the ticket?
> >>
> >> 2) Add sysdb_attrs_add_lower_case_string and make
> >> sysdb_attrs_add_lc_name_alias to utilize it? (attached patch does so)
> >
> >I would prefer 2.
> It is not clear for me from #2056 but ...
>
> Do we want to also replace "sysdb_attrs_add_string(attrs, SYSDB_NAME_ALIAS
..."
> with sysdb_attrs_add_lc_name_alias?
no, lower cased aliases are needed for case-insensitive searches, but
there might be other use-cases far aliases as well.