On 07/01/2011 04:44 PM, Stephen Gallagher wrote:
And now with patches attached...
On Fri, 2011-07-01 at 16:42 -0400, Stephen Gallagher wrote:
> So many changes have been made since the original pass that I have
> revisited the layout of my patches and have squashed many of them
> together. With these patches, we are fully compatible with the change to
> disable DENY rules in FreeIPA.
>
> Patch 0001: Add helper function msgs2attrs_array
> Unchanged from previous versions
>
> Patch 0002: Add HBAC evaluator and tests
> The evaluator library has changed its interface slightly. It now always
> returns an hbac_info object that contains the name of the rule that
> matched (if one did).
>
I only had time to review these two patches as the bindings are built on
top of them -- sorry.
0001 - unchanged, ack
0002 - ack, but please also fix the docstring of hbac_evaluate() before
pushing (error vs. info)