On (18/02/15 16:36), Stephen Gallagher wrote:
>
>
>
>On Tue, 2015-02-10 at 23:40 +0100, Lukas Slebodnik wrote:
>> ehlo,
>>
>> Attached patches:
>> * drop support for python < 2.6
>> * fix packaging of binding (backward incompatible change)
>> * add possibility to build python{2,3} bindings
>>
>> There are also small other enhancements.
>
>
>
>Patch 0005-0013: Ack
>
>Patch 0014:
>The Obsoletes: lines are wrong. These should really be < 1.12.5
>(presuming that this lands in 1.12.5, otherwise it should be be < 1.13)
>The Obsoletes needs to be static and always indicate the exact version
>at which we are replacing it. (The reasoning behind this is
>complicated). I'm not sure why you picked 1.9.90 here.
>
Nice catch.
It was copy and paste problem. I inspired in libsss_sudo which was obsoleted by
sssd-common.
The current version of sssd is
sh$ grep VERSION version.m4
m4_define([VERSION_NUMBER], [1.12.90])
So I used
Obsoletes: libipa_hbac-python < 1.12.90
I'm not sure wheter we shoudl push such changes to 1.12.5.
We can push some build patches but I would like to avoid doing big packaging
changes in stable release.
>Patch 0015:
>sss_obfuscate relies on pysss.so. We need to add a Requires: python-sss
>to the sssd-tools subpackage. (As noted on IRC, it also Requires:
>python-sssdconfig and that Requires: is also missing).
>
Added
>Also, the sss_obfuscate tool itself is currently hard-coded
>to /usr/bin/python (AKA python2). According to the Fedora packaging
>guidelines:
>"If only one executable is to be shipped, then it owns its own slot and
>should use /usr/bin/python3 from Fedora 22 on."[1]
I added simple sed command in last patch s/python/python3/
>
>Patch 0016:
>The three python tests (pyhbac-test.py, pysss_murmur-test.py and
>python-test.py) are only run against python 2 during 'make check'.
>Please run them against both versions. (This may require creating a
>wrapper script around them to force them to be called with python3)
>
I added wrappers in separate patch because the patch
"BUILD-Add-possibility-to-build-python-2-3-bindings" is complicated enough.
>Patch 0017: Ack
>
>Patch 0018:
>You typo python as "pyhton" in numerous places in the spec file.
>
Fixed
BTW: The meta pacakge sssd requires package "python-sssdconfig".
Do you remember why? Should we drop this requirements?
Thank you very much for review.
The new version of patchset is attached.
LS
>
>[1]
https://fedoraproject.org/wiki/Packaging:Python#Naming
>
I forgot to remove python3 bytecode files.
Updated version is attached.
LS