On 04/29/2010 07:27 AM, Sumit Bose wrote:
Sorry, the first patch had dependencies to another patch, new
version
attached.
bye,
Sumit
On Tue, Apr 27, 2010 at 02:08:02PM +0200, Sumit Bose wrote:
> Hi,
>
> this two patches add the support to display a warning to the user that
> the Kerberos password is about to expire. The first patch just moves
> some utility functions to a separate file to avoid linking the
> krb5_child against libdbus.
>
> I the second patch a prompter function is introduced to catch the
> warning message which is generated by libkrb5. With the current API of
> MIT Kerberos we have to rely on this message, because the the underlying
> AS_REPLY data is not exposed by the library. As a consequece this message
> cannot be translated, but this is true for messages which are generated
> to indicate why a password change failed, too. The rest of the patch
> changes the way the response from the child is packed and unpacked to
> allow more than one response message.
>
> bye,
> Sumit
Patch 0001: Ack
Patch 0002: The krb5_child_done() function is in desperate need of
comments. At minimum, there needs to be a comment describing the format
of the received buffer. Same for the pack_response_packet().
This is wrong:
if (msg_len > pref_len &&
strncmp((const char *) &buf[p], CCACHE_ENV_NAME"=",
pref_len) == 0) {
pref_len needs to be another byte longer to account for the '='. Also, a
comment here would be fantastic.
Otherwise this looks fine.
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/