>From 41ab67f2efe66602282d8baaf8a6101f614d3352 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 3 Apr 2013 10:15:37 +0200 Subject: [PATCH 2/4] Fix potential out-of-bounds write in sss_idmap_sid_to_dom_sid https://fedorahosted.org/sssd/ticket/1861 --- src/lib/idmap/sss_idmap_conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/idmap/sss_idmap_conv.c b/src/lib/idmap/sss_idmap_conv.c index a33604226f21315e12779fbbdd8971b8e8e250f4..ef93f2a9fb782fcba1bccacf100422d33bf65fee 100644 --- a/src/lib/idmap/sss_idmap_conv.c +++ b/src/lib/idmap/sss_idmap_conv.c @@ -289,7 +289,7 @@ enum idmap_error_code sss_idmap_sid_to_dom_sid(struct sss_idmap_ctx *ctx, } do { - if (dom_sid->num_auths > SID_SUB_AUTHS) { + if (dom_sid->num_auths >= SID_SUB_AUTHS) { err = IDMAP_SID_INVALID; goto done; } -- 1.8.1.4