On 08/19/2016 11:42 AM, Petr Cech wrote:
> On 08/19/2016 11:24 AM, Lukas Slebodnik wrote:
> > On (19/08/16 08:55), Petr Cech wrote:
> > > On 08/18/2016 12:22 PM, Petr Cech wrote:
> > > > On 08/18/2016 12:19 PM, Lukas Slebodnik wrote:
> > > > > ehlo,
> > > > >
> > > > > python wrapper for retrieving netgroups was push to early.
> > > > > Attached patch fixes it.
> > > > >
> > > > > LS
> > > >
> > > > Thanks, Lukas. I will take a look
> > > > and I will try it with my tests :-)
> > >
> > > Hi Lukas,
> > >
> > > your patch works how we expected.
> > >
> > > There are a few PEP8 issue:
> > >
> > > $ pep8 src/tests/intg/sssd_netgroup.py
> > > src/tests/intg/sssd_netgroup.py:131:80: E501 line too long
> > > src/tests/intg/sssd_netgroup.py:150:80: E501 line too long
> > > src/tests/intg/sssd_netgroup.py:151:80: E501 line too long
> > >
> > > Please, fix them.
> > >
> > It's just a WIP version which should unblock your testing?
> > and there are missing comments + other thigs.
>
> Great :-)
>
> > > I could say LGTM, but... you know, I have issue with my nested netgroups
> > > tests. I rather wait until I will resolve this one. And I will see
> > > that this
> > > your patch is final.
> > >
> > Do you need a help?
> >
> > BTW I think you need to use ldapmodify and I did something similar
> > in test for fetching extra attibutes.
> >
> >
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahoste...
> >
>
> Actually I work on ldapmodify now. I will take a look to your hint.
> Issue is that I has removed whole netgroups but I only need remove it
> from one which contains them.
>
> So, it is different remove A or A from B :-)
I just resolved tests for deleting on nested netgroups.
I will send patch very soon.
Your patch looks good to me. I am looking forward
to next version.