Jakub Hrozek wrote:
On 10/02/2009 06:49 PM, Dmitri Pal wrote:
> Updated versions are attached.
> Comments are inline.
ACK to all three
>>> 0001:
>>> * Is it possible to change the callbacks in elapi_resolve.c to static?
> Done
Just one thing, it is better to squash the changes to the file that
actually introduces the functions, that way you have them correct in the
first patch, rather than non-static in first patch and fixed to static
in second.
I agree, but I think I had two sets of changes in the same file: one set
for the first patch (changing to static) and another for the second (do
not remember).
To avoid doing editing and squashing twice I did it once and added on
top of the second patch.
Is it a bad practice? Seems like a bit of overkill to me to do it twice
but I am a novice to the common practices of git so please guide me :-).
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
--
Thank you,
Dmitri Pal
Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/