On 05/09/2016 04:51 PM, Petr Cech wrote:
On 05/09/2016 01:15 PM, Petr Cech wrote:
> On 05/05/2016 05:34 PM, Petr Cech wrote:
>> Hello,
>>
>> this patch resolves [1]. This adds new behaviour of negative caching of
>> locals, so it needs new tests. I will send patch with tests soon, but
>> not today.
>>
>> It is applicable after
>> RESPONDERS: Negcache in resp_ctx [2].
Hi,
patches works as expected. I would like you to rename few things
though... "locals" refers more to a resident and it is not being used in
the meaning of local users and groups. I'd rather use the word "local"
(singular), is_local (where boolean is used).
Please rename the new option into something more similar as
entry_negative_timeou, maybe local_negative_timeout,
unix_negative_timeout or files_negative_timeout...
Its man page description doesn't read well in english (especially the
second sentence). Maybe something like this would be better:
Specifies for how many seconds nss_sss should keep local users and
groups in negative cache before trying to look the up in the back end again.
Would it be beneficial to add some magic value (say -1) to represent
permanent ncache record?
Can you add some debuggin to is_user_local_by_name and similar functions
so we can see that local ncache timeout was used? Something like:
if (ret == EOK && pwd_result != NULL) {
DEBUG(SSSDBG_TRACE_FUNC, "User %s is a local user\n", name);
is_local = true;
}