On (29/01/16 10:22), Jakub Hrozek wrote:
On Thu, Jan 21, 2016 at 03:53:19PM +0200, Nikolai Kondrashov wrote:
> Hi Jakub, Michal, everyone,
>
> On 11/11/2015 07:03 PM, Michal Židek wrote:
> >I modified the "squashing" patch to remove the
> >workaround for failing memcache.
> >
> >SQUASH THESE 2 ATTACHED PATCHES BEFORE PUSHING
> >and use the commit message from Nick's
> >(first) patch (I altered the message a little
> >so that the removed test are not mentioned).
> >
> >CI link passed:
> >http://sssd-ci.duckdns.org/logs/job/32/83/summary.html
> >
> > From 904a94d406eaaa2a0f8389951b007552bfc04e1d Mon Sep 17 00:00:00 2001
> >From: Nikolai Kondrashov<Nikolai.Kondrashov(a)redhat.com>
> >Date: Tue, 29 Sep 2015 21:18:18 +0300
> >Subject: [PATCH 5/6] intg: Add more LDAP tests
> >
> >+def test_filter_users(request, ldap_conn, three_users_three_groups_rfc2307,
> >+def test_filter_groups_rfc2307(request, ldap_conn,
> >+def test_filter_groups_rfc2307_bis(request, ldap_conn,
> >
> > From da10890813f315826e60088fb938e581df504656 Mon Sep 17 00:00:00 2001
> >From: =?UTF-8?q?Michal=20=C5=BDidek?=<mzidek(a)redhat.com>
> >Date: Sun, 8 Nov 2015 22:17:44 +0100
> >Subject: [PATCH 6/6] Fixup this to Nick's patch
> >
> >-def test_filter_users(request, ldap_conn, three_users_three_groups_rfc2307,
> >-def test_filter_groups_rfc2307(request, ldap_conn,
> >-def test_filter_groups_rfc2307_bis(request, ldap_conn,
>
> These three tests didn't make it into our integration tests. IIRC, Michal
> wanted to refactor them, but I assume he had no time yet.
>
> What shall we do with them?
I looked at the integration tests today when I tried to write regression
test for a bug I found and I realized the current tests use enumeration.
It's very useful to test that codepath also, but non-enumeration is even
more useful. Perhaps we'll find some time next week to hack on the tests
so we can add the same ones, just with non-enum..
I think you ment ldap_tests.
Test for memory cache does not use enumeration :-)
LS