On Tue, Jan 13, 2015 at 05:43:40PM +0100, Pavel Reichl wrote:
On 01/13/2015 11:30 AM, Jakub Hrozek wrote:
>On Fri, Jan 09, 2015 at 05:11:38PM +0100, Pavel Reichl wrote:
>>On 01/09/2015 03:27 PM, Jakub Hrozek wrote:
>>>On Thu, Jan 08, 2015 at 01:26:15PM +0100, Pavel Reichl wrote:
>>>>On 01/07/2015 11:51 AM, Jakub Hrozek wrote:
>>>>>A very simple patch, see the commit message for details.
>>>>>
>>>>>
>>>>>_______________________________________________
>>>>>sssd-devel mailing list
>>>>>sssd-devel(a)lists.fedorahosted.org
>>>>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>>>I'm sorry, but I think you might have forgotten to remove the
duplicated
>>>>part of code from sysdb_gpo_get_gpo_result_setting()...?
>>>Yes :-)
>>>
>>>New patch is attached.
>>Please remove (unused) variable declarations:
>>
>>--- a/src/db/sysdb_gpo.c
>>+++ b/src/db/sysdb_gpo.c
>>@@ -591,8 +591,6 @@ sysdb_gpo_get_gpo_result_setting(TALLOC_CTX *mem_ctx,
>> const char **_ini_value)
>> {
>> errno_t ret;
>>- int lret;
>>- struct ldb_dn *base_dn;
>> TALLOC_CTX *tmp_ctx;
>> struct ldb_result *res;
>> const char *ini_value;
>
>thanks.. third time's the charm?
>
>new patch is attached.
yes, ACK :-)
* master: 4f4d35e14b4dc35a8df0ba28d6bd26f9ce75f962