-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/09/2010 02:02 PM, Stephen Gallagher wrote:
Thanks, new patch attached.
One more comment, in get_uid_from_pid():
+ }
+ DEBUG(1, ("read failed [%d][%s].\n", errno, +strerror(errno)));
+ return errno;
+ }
I think you should save errno somewhere, otherwise it will be
overwritten by printf() in the DEBUG() call.
Otherwise looks OK, although I'm wondering whether it makes sense to
have some kind of macro for loops around read() or write().
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkwPkVQACgkQHsardTLnvCWc8wCfWNVJ3Muws3t8wUm3NXM7FgTM
7EQAnjPSAVYFQ16gYkCna/gi/uJoYahG
=gfEY
-----END PGP SIGNATURE-----