On Fri, May 30, 2014 at 04:45:42PM +0200, Michal Židek wrote:
On 05/30/2014 03:37 PM, Stephen Gallagher wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>On 05/26/2014 01:21 PM, Jakub Hrozek wrote:
>>On Mon, May 26, 2014 at 10:38:23AM +0200, Jakub Hrozek wrote:
>>>Hi,
>>>
>>>the attached patch implements
>>>https://fedorahosted.org/sssd/ticket/2182 by adding three more
>>>options to the sss_usermod tool.
>>
>>> From 797a7101f58f9dd3c10c3ee08785e8de099aee0a Mon Sep 17 00:00:00
>>>2001 From: Jakub Hrozek <jhrozek(a)redhat.com> Date: Sun, 25 May
>>>2014 17:17:57 +0200 Subject: [PATCH] TOOLS: Allow adding and
>>>modifying custom attributes with sss_usermod
>>>
>>>https://fedorahosted.org/sssd/ticket/2182
>>>
>>>Adds three new options to the sss_usermod tool: --addattr
>>>--setattr --delattr
>>>
>>>The syntax is attrname=val1,val2, For example: sss_usermod
>>>--addattr=phone-123-456 tuser
>>>
>>>The operations are performed in the order of add, mod, del.
>>
>>Another version of the patch is attached. I fixed one formatting
>>issue in the man page and removed a useless comment from
>>sss_sync_ops.h (that was a leftover from myself moving one function
>>from public to static).
>>
>>The functionality is the same.
>>
>
>Ack to the manpage phrasing. (Not reviewing the code right now).
>
Ack for the code part.
Michal
Thanks for the review!
Pushed to master:
d10fb882aa4a30f78493b7162f482bb0f17d3ff5