On Sat, Jun 01, 2013 at 12:30:47AM -0700, C. S. wrote:
Enclosed is the squashed patch.
No worries, re-reading the thread I think I missed a few things early on.
You were suggesting adding an attribute to handle an alias on the master
map, which is why rfc2307_autofs_mobject_map and rfc2307bis_autofs_entry_map
would needed to have been updated(?).
Sorry, I can be very confusing sometimes. I was just pondering two
different options -- one was modifying the default_basic_opts array
which you did, the other was modifying the mobject and entry maps, which
I realized was the worse option.
In the latest patch, there are still additions to
rfc2307_autofs_mobject_map and rfc2307bis_autofs_entry_map which should
go away. Can you test the attached patch? It is your patch with those
two extra lines removed. If it works for you, I'll run the patch by
another engineer to be sure (I won't be able to push patch with my
additions myself then) and push.
The modified patch is attached.
Also, automounter works fine with different master map names, we use
production without issue at least. It was my understanding that sssd needs
to know the master map name so that it can expire it from the cache
properly on updates, is that correct? So in sssd.conf you also have
ldap_autofs_map_master_name = auto.slave, right?
Yes, correct. I modified both /etc/sysconfig/autofs and sssd.conf to
include the same master map called auto.slave.
Thanks again for your patience, much appreciated. ;-)
Thank you very much for the patch. Once the two additions to mobject and
mentry are removed, I'll simply push the patch. I didn't mean to confuse
you, sorry :)
On Thu, May 30, 2013 at 9:44 AM, Jakub Hrozek <jhrozek(a)redhat.com> wrote:
> On Tue, May 28, 2013 at 04:32:00PM -0700, C. S. wrote:
> > (Including once more as an attachment, it looks like something may have
> > wrapped the lines when I had the patch in the body of the message.)
> > On Tue, May 28, 2013 at 4:29 PM, C. S. <csleclish(a)gmail.com> wrote:
> > > Hi Jakub,
> > >
> > > Thanks for the feedback! Very helpful. Looks like I dropped the LDAP
> > > changes during a merge, that is now included. And I've removed the
> > > strdup(), whoops! ;-)
> > >
> > > cs
> > >
> Hi Cove,
> this patch is working for me with a couple of additonal changes that I
> attach as a mini-patch. If you like, you can squash it into yours and
> resend, then I think the patch would be good to go.
> Basically I think it's enough to have the master map name defined in the
> LDAP options, not the map and entry option lists. Also the option lists
> need the objectclass to be the first entry in the map.
> Sorry, I think I confused you with my previous e-mail.
> With the attached patch on top of yours, I was able to run automounter
> with a custom master map (MASTER_MAP_NAME="auto.slave" in
> /etc/sysconfig/autofs) just fine.
> Thanks again for the contribution.
> sssd-devel mailing list
sssd-devel mailing list