On 08/21/2015 03:40 PM, Petr Cech wrote:
On 08/21/2015 01:08 PM, Pavel Reichl wrote:
Hello Petr,

make dict check fails:
/workspace/ci/label/rhel7/ci-build-debug/sssd-1.13.1/_inst/share/locale\" -g3 -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c ../src/providers/ldap/ldap_id.c  -fPIC -DPIC -o src/providers/ldap/.libs/libsss_ldap_common_la-ldap_id.o
../src/providers/ldap/ldap_id.c:33:41: fatal error: providers/data_provider_req.h: No such file or directory
  #include "providers/data_provider_req.h"
you can fix this by something like:

Makefile.am
@@ -584,6 +584,7 @@ dist_noinst_HEADERS = \
     src/confdb/confdb_private.h \
     src/confdb/confdb_setup.h \
     src/providers/data_provider.h \
+    src/providers/data_provider_req.h \

I think that data_provider_req.h should be included in data_provider.h, you could save a lot of changes in source files that require both of them.
Thanks.
There is repaired patch attached.
Petr
Petr can you change data_provider_req.c to include

"providers/data_provider_req.h"

instead of

"providers/data_provider.h" ?

I originally thought that you will be able to include solely data_provider_req.h from responder_dp.c but I see that data_provider.h is required. But I still don't mind introducing data_provider_req.h.

If you change this little nitpick I think I can ACK the patch.