On Tue, Jan 07, 2014 at 07:55:59PM -0500, Stephen Gallagher wrote:
I've added a new patch 0004 that will create a systemd service
override in /etc/systemd/system/sssd.service.d/journal.conf
This file will have its contents commented out by default, but if it
is uncommented, the effect will be to redirect output to the journal.
This should vastly simplify the effort required.
Simo recommended that we may want to reverse the behavior (have the
journal be the standard destination if --with-syslog=journald was
passed to configure) and make the override capable of reverting to the
old behavior. This might have some real value (particularly for RHEL
7.0) so that we can migrate people easier while giving them an easy
way to get the old behavior back.
If we prefer to do it that way, I can quickly amend patch 0004 to do this.
I'm fine with defaulting to journald in the next major upstream release,
but RHEL-7.0 Beta was already out. I think *only* printing debug messages
to journald by default is too much of a change at this point..
>>>> suspect we'll want to discuss this before we make it the
>>>> default. This patch DOES change the default for sss_log
>>>> messages to use sd_journal_send() instead of straight log()
>>>> for those messages that we traditionally sent to the syslog
>>>> (such as login events). This is code that has been in place
>>>> for some time now, but has not been the default because we
>>>> hadn't build with --with-syslog=journald.
> ACK to this patch. Let me know your preference about splitting
> debug_fn, otherwise I think this patch is good to go along with
> re-adding the PRINTF_ATTRIBUTE.
I've fixed the PRINTF_ATTRIBUTE and split the debug_fn. New patches
Thank you, unfortunately these patches don't apply cleanly on top of the
latest version of Nikolai's patches, can you rebase them? I acked
Nikolai's patches, so hopefully this would be the last rebase..
So far I only read the diffs and they look good to me.