On 05/07/2010 11:17 AM, Eugene Indenbom wrote:
Oops, sorry about stray comment. I forgot that in recent changes
count check has been added.
No problem. It's not obvious from that code right there.
Yes, when we reach retry limit we should go offline.
In case of out of memory (or other error) it seems more correct to
report an error.
But as out of memory is the only possible error here going offline is OK.
Yeah, OOM should be incredibly rare (and fairly obvious), so I'm not too
worried about that.
BTW Please take a look into src/providers/ldap_id_enum.c. It contains
inclusions of sdap_check_gssapi_reconnect that are almost identical to
what you are fixing now.
Thanks for noticing that. I didn't think to check the enumeration code.
I'm doing a simple fix for that section.
Hopefully this is the final patch now.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.