On (08/04/14 13:00), Sumit Bose wrote:
On Mon, Apr 07, 2014 at 06:13:53PM +0200, Sumit Bose wrote:
> On Mon, Apr 07, 2014 at 02:22:04PM +0200, Pavel Reichl wrote:
> > Hello,
> >
> > I noticed these two warnings in clang.
> >
> > It would be great if the 2nd patch could be checked by Sumit to make
> > sure that the return value wasn't ignored on purpose.
>
> yes, I would prefer to ignore errors here. There might be various cases
> were we are not able to resolve a single SID but still can proceed with
> the others.
>
> The first patch looks good, I'll run some tests and will give my results
> later.
ACK to the first patch.
bye,
Sumit
Not all return point from function pac_lookup_sids_done were converted
using goto.
--
305- } else if (msg->count > 1) {
306- DEBUG(SSSDBG_CRIT_FAILURE, "More then one result returned "
\
307- "for SID [%s].\n",
308- entries[c].key.str);
309- talloc_free(msg);
310: pac_cmd_done(cctx, EINVAL);
311- return;
^^^^^^^
here
312- }
313-
314- id = ldb_msg_find_attr_as_uint64(msg->msgs[0],
315- SYSDB_UIDNUM, 0);
--
LS