-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/17/2010 08:12 AM, Simo Sorce wrote:
On Fri, 17 Dec 2010 07:25:43 -0500
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 12/16/2010 04:25 PM, Simo Sorce wrote:
>>> Patch 0002:
https://fedorahosted.org/sssd/ticket/713
>>
>> NACK, failing to set non-blocking should probably be a fatal
>> failure, as any operation would get us stuck on the socket blocking
>> everything else (signal processing and all).
>
>
> Excellent point. I've modified the patch to reflect this. (And also
> fixed a related issue in close-on-exec that I found nearby)
>
> Please re-review.
Looks good, but I am not sure if failing to set close-on-exec should be
a fatal failure. I don't think it can ever happen, but even if it does,
we leak a file at most.
OTOH, given it will never happen it is probably a good idea to return
an error if it ever happens so we can inspect what is going on as
someone will notice.
So ACK.
Pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk0LarQACgkQeiVVYja6o6NMkQCfRqEqOyw1qve4akMKnmhF6IcP
rEYAn0niD1yHUiEwSP/0TN6JF87miBBv
=ARs7
-----END PGP SIGNATURE-----