On 04/29/2010 07:41 AM, Stephen Gallagher wrote:
On 04/29/2010 05:52 AM, Sumit Bose wrote:
>> +
>> +static int online_cb_destructor(TALLOC_CTX *ptr);
>> +int be_add_online_cb(TALLOC_CTX *mem_ctx,
>> + struct be_ctx *ctx,
>> + be_conn_online_callback_t cb,
>> + void *pvt,
>> + struct be_conn_online_cb **online_cb)
>> +{
>> + struct be_conn_online_cb *on_cb;
>> +
>> + if (!ctx || !cb) {
>> + return EINVAL;
>> + }
>> +
>> + on_cb = talloc(mem_ctx, struct be_conn_online_cb);
>> + if (!online_cb) {
> if (!on_cb) ??
>
> bye,
> Sumit
Thanks for catching that. When I added the **online_cb return, I changed
the name of the internal struct to be on_cb, but I missed that use of
it. That would have been a bug, since it would have returned on error if
called without expecting a returned struct.
New patch attached.
Rebased to current sssd-1-2.
--
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/