On Wed, Apr 06, 2016 at 05:10:02PM +0200, Jakub Hrozek wrote:
> On Fri, Apr 01, 2016 at 03:17:00PM +0200, Lukas Slebodnik wrote:
> > On (31/03/16 09:46), Lukas Slebodnik wrote:
> > >On (18/03/16 17:53), Lukas Slebodnik wrote:
> > >>On (17/03/16 23:17), Jakub Hrozek wrote:
> > >>>On Mon, Mar 07, 2016 at 04:12:00PM +0100, Lukas Slebodnik wrote:
> > >>>> ehlo,
> > >>>>
> > >>>> simple patch is attached.
> > >>>>
> > >>>> LS
> > >>>
> > >>>Garbage-collecting easy patches untouched for a week or more..
> > >>>
> > >>>The patch looks good and according to:
> > >>>
http://sssd-ci.duckdns.org/logs/job/39/61/rhel6/ci-build-debug/ci-make-ch...
> > >>It should not be related to the patch.
> > >>
> > >I look deeply into the issue and it isn't realted to my patch.
> > >It's caused by slow down caused by valgrind.
> > >
> > >[==========] Running 3 test(s).
> > >[ RUN ] test_run_as_root_fg
> > >[ OK ] test_run_as_root_fg
> > >[ RUN ] test_run_as_sssd_fg
> > >[ OK ] test_run_as_sssd_fg
> > >[ RUN ] test_run_as_root_daemon
> > >killing 7393
> > >[ OK ] test_run_as_root_daemon
> > >[==========] 3 test(s) run.
> > >[ PASSED ] 3 test(s).
> > >PASS: server-tests
> > >As you can see test passed here. Because test_run_as_root_daemon
> > >check only creation of pid file and does not wait for full initialisation
> > >of server.
> > >
> > >(Thu Mar 17 07:49:13:826379 2016) [test_run_as_root_daemon] [ldb] (0x0020):
Unable to open tdb 'server_tests/config.ldb'(Thu Mar 17 07:49:13:899494 2016)
[test_run_as_root_daemon] [ldb] (0x0020): Failed to connect to
'server_tests/config.ldb' with backend 'tdb': Unable to open tdb
'server_tests/config.ldb'(Thu Mar 17 07:49:13:901723 2016)
[test_run_as_root_daemon] [confdb_init] (0x0010): Unable to open config database
[server_tests/config.ldb]
> > >(Thu Mar 17 07:49:13:905037 2016) [test_run_as_root_daemon] [server_setup]
(0x0010): The confdb initialization failed
> > >0x5 != 0
> > >/var/lib/jenkins/workspace/ci/label/rhel6/src/tests/cwrap/test_server.c:154:
error: Failure!
> > >
> > >[ FAILED ] test_run_as_root_daemon
> > >[==========] 3 test(s) run.
> > >[ PASSED ] 2 test(s).
> > >[ FAILED ] 1 test(s), listed below:
> > >[ FAILED ] test_run_as_root_daemon
> > >
> > >The failure is in child process due to race condition caused by slow
execution.
> > >
> > >The parent process in server-tests sent SIGTERM signal to child process.
> > >You can see a message "killing 7393" few lines before.
> > >But child process tried to initialize confdb even though it isn't
necessary
> > >here for this case.
> > >
> > >It isn't problem without valgrind becuase child process is fast enough.
> > >
> > >One solution can be to send SIGKILL to child process as part of cleanup
> > >in test_run_as_root_daemon. But that's not related to this patch :-)
> > >
> > >>You should look into build.log in ci-mock-result.
> > >>
> > >>However I could not see cmocka tests executed there.
> > >>Are you sure you provided link to build with this patch?
> > >>
> > >And now back to epel change in spec file.
> > >
> > >I could not see cmocka test executed in mock build output
> > >because "%{epel}" macro was not defined in epel6. It is
> > >only defined in epel7.
> > >
> > >You can compare following build logs
> >
>http://sssd-ci.duckdns.org/logs/job/39/61/rhel7/ci-build-debug/ci-mock-result/build.log
> >
>http://sssd-ci.duckdns.org/logs/job/39/61/rhel6/ci-build-debug/ci-mock-result/build.log
> > >
> > >However, fixed version of epel-rpm-macros-6-6 will be in testing
> > >in few hours :-)
> > >https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7c8a4eb5b6
> > >
> > Simplified version of spec file is attached.
> >
> > LS
>
> I tested the patch with a local mock build and saw all tests pass,
> including cwrap-powered tests.
>
> Thank you, ACK.
>
> Will push when CI finished.
CI:
http://sssd-ci.duckdns.org/logs/job/40/78/summary.html master:
* 6373d0111ee2e820d6e534d1a8b99de8587d08de
sssd-1-13:
* 0befc9ae024cf8c9a2d42ab21591699e659dd420
LS