On Thu, Mar 25, 2010 at 10:17:00AM -0400, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/25/2010 09:56 AM, Sumit Bose wrote:
>> NACK.
>
>> Please consider the following two comments:
>
>> - can you call free(user_msg) just after do_pam_conversation() to avoid to have
>> it two times?
>> - can you make buf in read_pipe_handler() a buf[MAX_CHILD_MSG_SIZE] or
>> put the read into a while loop to avoid the multiple memory allocation
>> for large messages?
>
>> Thanks.
>
>> bye,
>> Sumit
>
New patch attached. Thanks for the review.
ACK
bye,
Sumit
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkurcFsACgkQeiVVYja6o6NI5ACcDhFtJ+tyyTMF074mMVOP02Td
Bj4AnR4UxRVUG5IvluJkVr+RCJJXiq6D
=nIKf
-----END PGP SIGNATURE-----