On Fri, May 14, 2010 at 11:55:01AM -0400, Stephen Gallagher wrote:
On 05/14/2010 08:29 AM, Sumit Bose wrote:
> this series of patches aims to fix the handling of the info file for the
> locator plugin to allow a graceful fallback to the configuration from
> krb5.conf is the sssd backend is offline.
> Remove the old commit
> Remove references to 'online' from the main callback code, move
> callback code to a separate file to make life easier for potential
> unit test.
Nack. Please condense be_run_offline_cb() and be_run_online_cb() into a
single function. They are nearly identical already.
ok, I've put the common code into a new function. Most of the changes
are in 0002.
> Create a new subroutine which only unlinks the files.
Nitpick: you added an extra "ret = EOK" into ipa_service_init()
New versions attached.
> KRB5_PLUGIN_NO_HANDLE is the error code which instructs libkrb5 to
> try the next plugin of use krb5.conf.
sssd-devel mailing list