On Thu, 2012-05-03 at 16:51 +0200, Jakub Hrozek wrote:
The mail is getting too big, I'm going to trim the acked
patches.
ldap_group_objectsid seems to be still missing from src/config/SSSDConfig.py
Man, this just keeps biting me. Fixed.
> > > > Patch 0012: Look up mapped users by UID
> > >
> > > UID and GID values are 32bit unsigned values in general, right?
Wouldn't it
> > > be better to use strtouint32() and not strtoint32(), then to avoid errors
> > > when a very large ID is requested? The strto(u)int32 functions also set
> > > errno to 0 themselves, no need to do it manually.
> > >
>
> The errno thing isn't harmful, so I'm not going to bother with it. It
> actually turns out that id_t (as well as uid_t and gid_t) are actually
> *signed* values, not unsigned. This has actually caused us issues
> elsewhere before. See
https://fedorahosted.org/sssd/ticket/1216 for
> details.
Wasn't that bug just a matter of /proc not representing the data
correctly? On my system, both uid_t and gid_t eventually resolve to
unsigned int (through a __U32_TYPE constant).
Yeah, you're right. I switched them over to strtouint32 and removed the
errno=0. Same for patch 0014.
All patches reattached, but only those three have changed.