On (27/06/16 11:42), Pavel Březina wrote:
On 06/16/2016 07:28 PM, Lukas Slebodnik wrote:
> ehlo,
>
> attached is a patch for TEVENT_REQ_RETURN_ON_ERROR
> which was discussed in dp_provider related thread.
>
> It "fixes" 6 clang warnings
> and 150 UNINIT from coverity (visible only in --agresive mode)
>
> BTW feel fre to prose different error code
> for result of down casting == 0.
> It should not happen but one never knows.
>
> LS
I'd say ERR_INTERNAL or custom error code is more suitable. The same thing
can happen also in sdap_cli_connect_recv(). Can you fix it there as well?
I found
few more places.
Updated patch is attached.
LS