-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/12/2010 10:18 AM, Sumit Bose wrote:
On Mon, Oct 11, 2010 at 02:32:59PM -0400, Stephen Gallagher wrote:
Also, I'm not sure that this is safe for aligned platforms like MIPS. It
might be wisest to just make this a 32-bit value and use the alignment
code here.
> Currently it is handled as char/uint8_t, so it shouldn't be an issue. But
> if you prefer a uint32_t here I can change it. One other reason to
> change it would be that we always use uint32_t for such things in the
> wire protocol. What do you think?
Yeah, I'd prefer to remain consistent. Using a 32-bit value here gives
us the option in the future to co-opt the high-order bits for something
else, as well.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAky0fZwACgkQeiVVYja6o6OWNACgn5Fq46yMdWRaGv9Y6L48q5b/
30wAoJgcoGei/Zdby4vdjNR2ycB6CT2g
=WjDe
-----END PGP SIGNATURE-----