>From e2a5673730326a435708f88fe291f55675f18c83 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 6 Mar 2015 20:45:39 +0100 Subject: [PATCH 1/2] sysdb-tests: Add missing assertions The return valuee of functions test_remove_group_member sysdb_attrs_add_time_t were ignored and therefore this part of code was not tested. --- src/tests/sysdb-tests.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/sysdb-tests.c b/src/tests/sysdb-tests.c index 7c2c6d208127b0b6f9025435619b027246c6dd35..7b150591b47724e76e3d876be1de7d48da3ff5cf 100644 --- a/src/tests/sysdb-tests.c +++ b/src/tests/sysdb-tests.c @@ -1440,6 +1440,7 @@ START_TEST (test_sysdb_remove_group_member) data->uid = _i - 1000; /* the UID of user to add */ ret = test_remove_group_member(data); + fail_if(ret != EOK, "Remove group member failed: %d", ret); talloc_free(test_ctx); } @@ -1894,6 +1895,8 @@ static void cached_authentication_with_expiration(const char *username, data->attrs = sysdb_new_attrs(data); ret = sysdb_attrs_add_time_t(data->attrs, SYSDB_LAST_ONLINE_AUTH, now); + fail_unless(ret == EOK, "Could not mdd attribute "SYSDB_LAST_ONLINE_AUTH + ": %s", data->username); ret = sysdb_set_user_attr(data->ctx->domain, data->username, data->attrs, SYSDB_MOD_REP); -- 2.3.5