On Mon, Apr 14, 2014 at 12:50:33PM +0200, Jakub Hrozek wrote:
On Fri, Apr 11, 2014 at 03:28:30PM +0200, Pavel Reichl wrote:
> On Fri, 2014-04-11 at 12:16 +0200, Jakub Hrozek wrote:
> > On Wed, Apr 09, 2014 at 02:29:05PM +0200, Pavel Reichl wrote:
> > > Hello,
> > >
> > > please see attached patch.
> > >
> > > This patch was previously written for BZ 1059423. But it now seems that
> > > more detailed logging information is generally useful for issues that
> > > are emerging from this area lately.
> > >
> > > Pavel Reichl
> >
> > Hi,
> >
> > this patch is OK, but I think we should also add more debugging to
> > sdap_save_grpmem().
> >
> > Would it be too much work to also apply the patch to 1.11 ? I think it
> > might come handy with the planned RHEL-6.6 rebase..
>
> Hi,
>
> I added 3 log messages to sdap_save_grpmem() and 1 to sysdb_store_group.
> I actually can't see any other good spot to add logging in
> sdap_save_grpmem(), but I could add more logging messages into functions
> which are called from here...?
>
> I'll be happy to prepare patch for 1.11 but I would prefer to have acked
> patch for master before doing so.
>
> Thanks.
I think the current version is good and sdap_save_grpmem() is now
documented well.
ACK
Can you also send a version for 1.11 ?
Pushed to master: 9123c2abff5780f485764261eb4b180e9ceadf20