On 01/12/2016 04:46 PM, Pavel Reichl wrote:
> I would add a test where you set the idmap parameters to some smaller
> values than the default, e.g. range size to 10 and the number of initial
> slices to 5. Then initialize the id-mapping for some domain and run a
> loop with rid values from 0 to 80, call sss_idmap_sid_to_unix() and save
> the POSIX IDs in an array. Then run sss_idmap_unix_to_sid() with the
> values from the array and check if the expected SID is returned. This
> will exercise adding more slices than initialized at startup and make
> sure that there are no gaps between the slices or off-by-one errors at
> the boundary of the slices.
OK, I will work on this now.
Done in attached patch (only change in the patch set).
> Additionally I think it would be more reliable if the secondary slices
> can be saved to the cache and can be read at startup as well. I'm
> thinking of the case when there is a collision in the secondary slices
> of different domains. Currently we try to find a unused slice if a
> collision is detected. But if after a restart the slices are initialized
> in a different order the colliding slices might get swapped. Maybe
> callbacks can be added to sss_idmap_add_auto_domain_ex() which can be
> set to a function which can reads and writes the data from the cache?
OK, I will work on this after the test is done.
Working on this now.
> sssd-devel mailing list
sssd-devel mailing list