Simo Sorce wrote:
On Fri, 2009-10-30 at 14:07 +0100, Martin Nagy wrote:
> Hi,
> attached are patches needed for the fail over functionality. The
> service discovery is not there yet, I want to hold of with that until I
> have at least a basic SRV-based one so I can test it properly. It's
> possible that we will discover something missing when we'll be
> integrating it into providers. Together with Steven we at least figured
> out that for ldapi:// for example we need an "extra" treatment. So I
> made the name resolution optional and you can provide a server with
> user data. The commit messages and header files should explain it
> better.
Martin,
why there are so many static global variables in this code ?
(static struct { ... } global ....)
Why aren't you using a context based approach like all the rest of the
code in sssd ?
Simo.
My reason was that I thought it might not be easy to share one context.
If I would use a context base approach then we would have to make sure
that every provider uses the same one. If you think this is not a
problem I'll gladly change the patch. Since a pointer to a context
could be stored in struct service for example, you would only need it
in few calls anyway.
Martin