On Thu, 2013-03-07 at 08:35 -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/07/2013 08:22 AM, Sumit Bose wrote:
> Hi,
>
> please have a look at
>
https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient
>
>
This is my understanding about what needs to be done to replace winbind
> with sssd with respect to a CIFS client, i.e. cifs kernel module
> and cifs-utils packages.
>
> For your convenience the content is added below as well.
>
> Comments and suggestions are welcome.
>
Looks straightforward to me, given the plugin infrastructure that Jeff
Layton made available. I've edited the page to correct a few typos for
readability, but this approach looks pretty sound to me.
I'd like to suggest that we probably would want to implement an
in-memory cache in the cifs plugin, however. In some situations, we
may see many requests for the same conversion in a short period of
time. It's probably in our best interest to maintain a fast cache of
these conversions.
The kernel does caching, not sure we need to add more on top.
I'm not certain of the architecture of cifs-utils. Is it usually
invoked as part of a long-running process, or is it common to call a
helper binary to do the processing normally. If the latter, then we
can probably just maintain a hash table in the plugin to store the
conversions for the life of the helper app. If it's possible that the
app may be long-running, then we probably need to make sure to set a
lifetime on the in-memory cache entries.
The cifs.upcall can stay around but may be restarted at any time.
I would avoid additional caches prematurely though, unless we see a real
need.
Simo.
--
Simo Sorce * Red Hat, Inc * New York