On (21/01/16 11:22), Pavel Březina wrote:
>On 01/20/2016 01:54 PM, Lukas Slebodnik wrote:
>>On (20/01/16 13:09), Pavel Březina wrote:
>>>I think this is not necessary... or is there any specific reason?
>>
>>>From b24cc925e5d22b02a17b31e20d8ce4f8a3c2eb51 Mon Sep 17 00:00:00 2001
>>>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
>>>Date: Fri, 15 Jan 2016 13:39:04 +0100
>>>Subject: [PATCH 01/12] Do not compile generated header files
>>>
>>>---
>>>Makefile.am | 23 +++++++++++------------
>>>1 file changed, 11 insertions(+), 12 deletions(-)
>>>
>>>diff --git a/Makefile.am b/Makefile.am
>>>index
6008b06ddf45fa8c6558876db37d9d07788ca9da..30fa4aebf3b3163323e5794fad288f2fbb055136 100644
>>>--- a/Makefile.am
>>>+++ b/Makefile.am
>>>@@ -458,9 +458,7 @@ SSSD_RESPONDER_OBJ = \
>>> src/responder/common/responder_utils.c \
>>> src/responder/common/responder_cache_req.c \
>>> src/monitor/monitor_iface_generated.c \
>>>- src/monitor/monitor_iface_generated.h \
>>> src/providers/data_provider_iface_generated.c \
>>>- src/providers/data_provider_iface_generated.h \
>>> src/providers/data_provider_req.c
>>>
>>>SSSD_TOOLS_OBJ = \
>>>@@ -559,6 +557,7 @@ dist_noinst_HEADERS = \
>>> src/util/util_sss_idmap.h \
>>> src/monitor/monitor.h \
>>> src/monitor/monitor_interfaces.h \
>>>+ src/monitor/monitor_iface_generated.h \
>>> src/responder/common/responder.h \
>>> src/responder/common/responder_packet.h \
>>> src/responder/common/responder_sbus.h \
>>>@@ -575,6 +574,7 @@ dist_noinst_HEADERS = \
>>> src/responder/sudo/sudosrv_private.h \
>>> src/responder/autofs/autofs_private.h \
>>> src/responder/ssh/sshsrv_private.h \
>>>+ src/responder/ifp/ifp_iface_generated.h \
>>> src/responder/ifp/ifp_private.h \
>>> src/responder/ifp/ifp_domains.h \
>>> src/responder/ifp/ifp_components.h \
>>>@@ -647,6 +647,7 @@ dist_noinst_HEADERS = \
>>> src/providers/ipa/ipa_sudo.h \
>>> src/providers/ad/ad_srv.h \
>>> src/providers/proxy/proxy.h \
>>>+ src/providers/data_provider_iface_generated.h \
>>Patch make sense header files needn't be listed as a dependencies
>>for binary files (libraries). Dependency on header files should
>>be automatically generated by compiler (or libtool) IIRC.
>>
>>make distcheck passed but would you mind to move previous header files to
>>different place in dist_noinst_HEADERS.
>>
>>Here is a diff
>>diff --git a/Makefile.am b/Makefile.am
>>index 30fa4ae..12ddeba 100644
>>--- a/Makefile.am
>>+++ b/Makefile.am
>>@@ -599,6 +599,7 @@ dist_noinst_HEADERS = \
>> src/confdb/confdb_setup.h \
>> src/providers/data_provider.h \
>> src/providers/data_provider_req.h \
>>+ src/providers/data_provider_iface_generated.h \
>> src/providers/dp_backend.h \
>> src/providers/dp_dyndns.h \
>> src/providers/dp_ptask_private.h \
>>@@ -647,7 +648,6 @@ dist_noinst_HEADERS = \
>> src/providers/ipa/ipa_sudo.h \
>> src/providers/ad/ad_srv.h \
>> src/providers/proxy/proxy.h \
>>- src/providers/data_provider_iface_generated.h \
>> src/tools/tools_util.h \
>> src/tools/sss_sync_ops.h \
>> src/resolv/async_resolv.h \
>>
>>
>>I looks better src/providers/data_provider* header files are together :-)
>
>Attached.
>
>From 7d7da72862bcf4c8ba91db3e9cd031fedd9bfd80 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
>Date: Fri, 15 Jan 2016 13:39:04 +0100
>Subject: [PATCH 01/13] Do not compile generated header files
>
>---
> Makefile.am | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
ACK
http://sssd-ci.duckdns.org/logs/job/36/59/summary.html