On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote:
On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote:
Hi,
this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 "Handle overriden name of members in the memberUid attribute".
So far I read them to get a grasp of what they do, but didn't do a full review. See some comments below.
I also submitted the patches to Coverity which found a warning: Error: COMPILER_WARNING: sssd-1.14.1/src/util/util.h:54: included_from: Included from here. sssd-1.14.1/src/db/sysdb_ops.c:22: included_from: Included from here. sssd-1.14.1/src/db/sysdb_ops.c: scope_hint: In function 'sysdb_get_user_members_recursively' sssd-1.14.1/src/db/sysdb_ops.c:4879:36: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'long unsigned int' [-Wformat=] # DEBUG(SSSDBG_CRIT_FAILURE, "More then [%llu] results.\n", UINTMAX_MAX); # ^ sssd-1.14.1/src/util/debug.h:108:22: note: in definition of macro 'DEBUG' # format, ##__VA_ARGS__); \ # ^ # 4877| res->count = count; # 4878| } else { # 4879|-> DEBUG(SSSDBG_CRIT_FAILURE, "More then [%llu] results.\n", UINTMAX_MAX); # 4880| ret = EINVAL; # 4881| goto done;
Error: COMPILER_WARNING: sssd-1.14.1/src/providers/ipa/ipa_subdomains_id.c: scope_hint: In function 'ipa_check_ghost_members_done' sssd-1.14.1/src/providers/ipa/ipa_subdomains_id.c:1250:35: warning: unused variable 'state' [-Wunused-variable] # struct ipa_get_ad_acct_state *state = tevent_req_data(req, # ^ # 1248| struct tevent_req *req = tevent_req_callback_data(subreq, # 1249| struct tevent_req); # 1250|-> struct ipa_get_ad_acct_state *state = tevent_req_data(req, # 1251| struct ipa_get_ad_acct_state); # 1252| int ret;