On 06/23/2016 06:52 PM, Lukas Slebodnik wrote:
> On (23/06/16 18:24), Michal Židek wrote:
> > On 06/23/2016 05:50 PM, Michal Židek wrote:
> > > Lukas,
> > >
> > > did you have some local patches related to
> > > this patch, that you did not send here?
> > >
> > > Because I can not apply the patch on current
> > > master and the changes in the context of
> > > your patch seem like you did something with
> > > default config file path?
> > >
> > > Slightly modified version that applies on
> > > current master is attached (the changes
> > > are the same, but the context differs).
> > >
> > > Michal
> > >
> >
> > I added the missing access check for
> > snippets. If the snippets does not
> > pass the access check it is skipped
> > and a loud debug message is logged.
> >
> > I attach it as separate patch for
> > easier review, but it should be squashed
> > before pushing. I also attach the first
> > patch for convenience.
> >
> > Michal
>
> > From 6299c0c9e2d07f0764be80e73334e3cdc2ba2b12 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> > Date: Tue, 22 Mar 2016 14:09:34 +0100
> > Subject: [PATCH] confdb: Make it possible to use config snippets
> >
> > Resolves:
> >
https://fedorahosted.org/sssd/ticket/2247
> >
> > Signed-off-by: Lukas Slebodnik <lslebodn(a)redhat.com>
> > ---
LGTM.
It isn't ACK because I was involved in development
and I didn;t test last version but code is fine fore me.
LS